Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc about long-running traces #3977

Merged
merged 10 commits into from
Aug 22, 2024
Merged

Conversation

zalegrala
Copy link
Contributor

What this PR does:

Here we add a bit of doc to point folks at when they are using the long-running trace pattern.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@knylander-grafana
Copy link
Contributor

@zalegrala Let me know when you want me to review. Thank you for adding doc!

@zalegrala
Copy link
Contributor Author

I'll take review any time @knylander-grafana. Do you have thoughts?

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the doc! A few minor suggestions, but otherwise looks good.

@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label Aug 21, 2024
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm good! nice addition

@zalegrala zalegrala merged commit 457a563 into grafana:main Aug 22, 2024
17 checks passed
@zalegrala zalegrala deleted the longRunningTraceDoc branch August 23, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants