Convert tenant index to proto in the backend #4023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
changed the title
zalegrala
changed the title
zalegrala
commented
Aug 29, 2024
zalegrala
force-pushed
the
tenantIndexProtoMinimal
branch
from
7271b8e
to
79a4bc3
Compare
zalegrala
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
electron0zero,
ie-pham and
stoewer
as code owners
zalegrala
commented
Aug 30, 2024
zalegrala
force-pushed
the
tenantIndexProtoMinimal
branch
from
b251d02
to
bf0bd33
Compare
mapno
approved these changes
Sep 2, 2024
joe-elliott
reviewed
Sep 3, 2024
zalegrala
force-pushed
the
tenantIndexProtoMinimal
branch
from
bf0bd33
to
7481c6a
Compare
This reverts commit 4aa87f8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In large clusters, a significant portion of the poller memory is used
unmarshaling json for the tenant index. This PR converts the tenant index to a
proto to reduce memory usage.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]