Speedup collection of results from ingesters in the querier #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
force-pushed
the
ingester_collection_perf
branch
from
40bbcb8
to
708508f
Compare
electron0zero
force-pushed
the
ingester_collection_perf
branch
from
708508f
to
2b8b2b1
Compare
electron0zero
force-pushed
the
ingester_collection_perf
branch
from
b9450d7
to
d45a9f0
Compare
electron0zero
force-pushed
the
ingester_collection_perf
branch
from
d45a9f0
to
f3c7600
Compare
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
ie-pham and
stoewer
as code owners
mdisibio
reviewed
Sep 23, 2024
3 tasks
mapno
approved these changes
Sep 25, 2024
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Sep 26, 2024
…4100) * Add Generic Collector for collection of things * push collection down to calls to ingester * fixup generic collector * cleanup comments and TODOs * Update CHANGELOG.md * match span name with func name * inline the collection of results in SearchRecent * remove break goto * make ScopedDistinctString and DistinctString safe + test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Earlier we used to make calls to ingesters, get results and itarate over these results to collect them and then return them to query-frontend.
Iterating and then collecting the results was sync and a bottleneck and showed up in traces and profiles.
This PR pushed down the collection of results and that makes it a parallel and removes the iteration step.
now we query an ingester and collect the results where we query, and once all ingesters response, we read the collected results and return them to query-frontend for further combining.
see this trace for example:
along with these changes, It also does the following:
interface{}return types fromforIngesterRingsand callback functionforEachFnWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]