fix_3811: send semver version in api/stattus/buildinfo for cloud deployments #4110
+69
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aki0x137
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
|
|
joe-elliott
reviewed
Sep 24, 2024
| run: | | ||
| if [ -n "$(git status --porcelain VERSION)" ]; then | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" |
There was a problem hiding this comment.
@ie-pham do you think this will work with our latest security changes to GHA?
i'll admit i'm not sure where the creds are that allow this to work?
| VERSION=$(cat "${REPO_ROOT}/VERSION" ) | ||
| if is_valid_semver "$VERSION"; then | ||
| echo "$VERSION" | ||
| exit 0 |
There was a problem hiding this comment.
So I believe that changing this script will update the version as expected b/c of this line:
https://github.com/grafana/tempo/blob/main/Makefile#L50
However I think it will also change the output of the script as used here:
https://github.com/grafana/tempo/blob/main/.drone/drone.yml#L12
which I'm pretty sure is how our docker images are tagged:
https://hub.docker.com/r/grafana/tempo/tags
@zalegrala do you know off the top of your head if this is how it works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
image-tagtool is updated to validate and use the semver version, if present. Otherwise default to current behavior.Which issue(s) this PR fixes:
Fixes #3811
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]