Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect passed headers in read path requests #4287

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mapno
Copy link
Member

@mapno mapno commented Nov 5, 2024

What this PR does:

#4242 broke compatibility with non-vanilla distributions of Tempo that rely on headers in the read path.

This PR respects headers in queries and forwards them to queriers as before.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@javiermolinar javiermolinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change was ok, we need to identify the missing header (X-Org-id or Authorization) and add it to the prepareRequestForQueriers

Copy link
Contributor

@mdisibio mdisibio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM, lean towards reverting this behavior now to fix things, and we can revisit the alloc savings once we know more.

@joe-elliott joe-elliott merged commit 3449ef6 into grafana:main Nov 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants