Use Credentials.IsEmpty

common/frame_session.go

@@ -1149,7 +1149,7 @@ func (fs *FrameSession) updateHTTPCredentials(initial bool) error {
 	fs.logger.Debugf("NewFrameSession:updateHttpCredentials", "sid:%v tid:%v", fs.session.ID(), fs.targetID)
 
 	credentials := fs.page.browserCtx.opts.HTTPCredentials
-	if !initial || credentials != (Credentials{}) {
+	if !initial || !credentials.IsEmpty() {
 		return fs.networkManager.Authenticate(credentials)
 	}
 

common/network_manager.go

@@ -614,7 +614,7 @@ func (m *NetworkManager) onAuthRequired(event *fetch.EventAuthRequired) {
 	case m.attemptedAuth[rid]:
 		delete(m.attemptedAuth, rid)
 		res = fetch.AuthChallengeResponseResponseCancelAuth
-	case m.credentials != Credentials{}:
+	case !m.credentials.IsEmpty():
 		// TODO: remove requests from attemptedAuth when:
 		//       - request is redirected
 		//       - loading finished
@@ -721,7 +721,7 @@ func (m *NetworkManager) updateProtocolRequestInterception() error {
 // Authenticate sets HTTP authentication credentials to use.
 func (m *NetworkManager) Authenticate(credentials Credentials) error {
 	m.credentials = credentials
-	if credentials != (Credentials{}) {
+	if !credentials.IsEmpty() {
 		m.userReqInterceptionEnabled = true
 	}
 	if err := m.updateProtocolRequestInterception(); err != nil {

tests/browser_context_options_test.go

@@ -24,7 +24,7 @@ func TestBrowserContextOptionsDefaultValues(t *testing.T) {
 	assert.Empty(t, opts.ExtraHTTPHeaders)
 	assert.Nil(t, opts.Geolocation)
 	assert.False(t, opts.HasTouch)
-	assert.Nil(t, opts.HTTPCredentials)
+	assert.True(t, opts.HTTPCredentials.IsEmpty())
 	assert.False(t, opts.IgnoreHTTPSErrors)
 	assert.False(t, opts.IsMobile)
 	assert.True(t, opts.JavaScriptEnabled)