Desobekify Viewport
#1520
Merged
Desobekify Viewport
#1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
desobekify/viewport
branch
from
d16f456
to
7bd2f21
Compare
inancgumus
force-pushed
the
desobekify/screen
branch
from
13bd06d
to
e1ea43e
Compare
inancgumus
requested review from
oleiade and
olegbespalov
and removed request for
a team
This pattern we use is similar to https://pkg.go.dev/time#Time.Add. Instead of using a pointer and updating a simple value in place, we return a new one.
inancgumus
force-pushed
the
desobekify/viewport
branch
from
7bd2f21
to
380d03c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Viewport.Viewportinto a value type.Why?
See "Desobekifying Sobek transformation" at #1064.
Checklist
Related PR(s)/Issue(s)
BrowserContextmethods #1270