Skip to content

Commit

Permalink
quick fix: prevent flaky test (#284)
Browse files Browse the repository at this point in the history
Signed-off-by: Pablo Chacin <[email protected]>
  • Loading branch information
pablochacin authored Aug 8, 2023
1 parent 7d609bc commit b521df3
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions pkg/kubernetes/helpers/pods_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ func TestPods_Wait(t *testing.T) {
}
}

//nolint:tparallel // serialize tests until issue #280 is fixed
func TestPods_AddEphemeralContainer(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -157,7 +158,7 @@ func TestPods_AddEphemeralContainer(t *testing.T) {
},
},
options: AttachOptions{
Timeout: 5 * time.Second,
Timeout: 1 * time.Second,
IgnoreIfExists: true,
},
},
Expand All @@ -172,16 +173,17 @@ func TestPods_AddEphemeralContainer(t *testing.T) {
},
},
options: AttachOptions{
Timeout: 3 * time.Second,
Timeout: 1 * time.Second,
IgnoreIfExists: true,
},
},
}
//nolint:paralleltest // serialize tests until issue #280 is fixed
for _, tc := range testCases {
tc := tc

t.Run(tc.test, func(t *testing.T) {
t.Parallel()
// t.Parallel()

pod := builders.NewPodBuilder(tc.podName).
WithNamespace(testNamespace).
Expand Down

0 comments on commit b521df3

Please sign in to comment.