-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support k8s oidc auth #429
Conversation
Hi @Ugzuzg thanks for submitting this contribution. As I mentioned in the issue you opened (#429) my main concern is about how to test this change. As I can see from the checklist you haven't tested it yourself. I ran the integration tests and haven't noticed any regression, but I can't tell if it will actually solve the issue. I suppose you have an environment where you can test it. Is there a way you can test it without we releasing a new version? |
I have tested it locally and was able to send disruptions using OIDC auth config. I haven't checked any of the testing checkboxes, because all of them seem to be concerned with running automated tests, and don't apply to the manual test that I have done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Ugzuzg the linter is failing due to this error. Can you please add a comment to this line explaining why this is needed? Something like
|
@pablochacin, now linter is passing locally. |
Description
Fixes #412
Checklist:
make lint
) and all checks pass.make test
) and all tests pass.make integration-xxx
for affected packages)make e2e-xxx
fordisruptors
, orcluster
related changes)