Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javax to jakarta, groovy 4, spring framework 6 and spring boot 3 migrations #878

Merged
merged 16 commits into from
Aug 28, 2024

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Aug 22, 2024

PR so that a 9.0.0-SNAPSHOT can be published and we can continue working on other grails dependencies while we work on the failing tests ignored on this PR. #879

Requires grails/grails-data-mapping#1810 changes and org.grails:grails-datastore-*:9.0.0-SNAPSHOT

Key Changes and Issues:

Groovy-5106 issues:

The interface GormEntity cannot be implemented more than once with different arguments: org.grails.datastore.gorm.GormEntity<grails.gorm.tests.XXX> and org.grails.datastore.gorm.GormEntity<grails.gorm.tests.XXX>

examples-grails-data-service

General error during canonicalization: No signature of method: org.codehaus.groovy.ast.ClassCodeExpressionTransformer.transform() is applicable for argument types: (org.codehaus.groovy.ast.expr.MethodCallExpression) values: [org.codehaus.groovy.ast.expr.MethodCallExpression@776b49b2[object: org.codehaus.groovy.ast.expr.VariableExpression@30b9eadd[variable: response] method: org.codehaus.groovy.ast.expr.ConstantExpression@497570fb[status] arguments: org.codehaus.groovy.ast.expr.ArgumentListExpression@412c995d[org.codehaus.groovy.ast.expr.PropertyExpression@3249a1ce[object: org.codehaus.groovy.ast.expr.ClassExpression@4dd94a58[type: org.springframework.http.HttpStatus] property: org.codehaus.groovy.ast.expr.ConstantExpression@2f4919b0[UNPROCESSABLE_ENTITY]]]]]

https://github.com/grails/gorm-hibernate5/pull/878/files#diff-12879bcb16768df7b12cc0afc7feb7dec6daac16cc78ab20d97a86461a37771f
java.lang.IllegalStateException: Either class [example.Customer] is not a domain class or GORM has not been initialized correctly or has already been shutdown. Ensure GORM is loaded and configured correctly before calling any methods on a GORM entity.

https://github.com/grails/gorm-hibernate5/pull/878/files#diff-b959418ad6dfb5509464cf7b01fe22b84cf1d72f4756299d9382f2f5afded695
java.lang.IllegalStateException: Either class [example.Book] is not a domain class or GORM has not been initialized correctly or has already been shutdown. Ensure GORM is loaded and configured correctly before calling any methods on a GORM entity.
java.lang.IllegalStateException: Either class [example.Book] is not a domain class or GORM has not been initialized correctly or has already been shutdown. Ensure GORM is loaded and configured correctly before calling any methods on a GORM entity.

Additional currently failing tests.

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2024

CLA assistant check
All committers have signed the CLA.

@jamesfredley jamesfredley changed the title javax to jarakarta, groovy 4, spring framework 6 and spring boot 3 migrations javax to jakarta, groovy 4, spring framework 6 and spring boot 3 migrations Aug 22, 2024
@grails grails deleted a comment from CLAassistant Aug 22, 2024
.github/workflows/docs.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@jamesfredley
Copy link
Contributor Author

jamesfredley commented Aug 22, 2024

The failing tests on these changes will require a material effort to resolve, but for now should wait until the Grails 7 apps start.

Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I don't think the joint workflow is working as intended. It builds a Groovy Snapshot, but then fetches the published Snapshot from the Snapshot repo.

I think we should do publishToMavenLocal instead of install from the groovy build. Then the grails build will find the fresh Snapshot by having a mavenLocal() repo.

@jamesfredley
Copy link
Contributor Author

I have updated this repo to use publishToMavenLocal.

@jamesfredley jamesfredley merged commit 757eade into grails:9.0.x Aug 28, 2024
7 checks passed
@jamesfredley jamesfredley deleted the jamesfredley/9.0.x-changes branch August 28, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants