Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark GORM created code as @Generated. #1445

Open
aulea opened this issue Mar 20, 2021 · 2 comments
Open

Mark GORM created code as @Generated. #1445

aulea opened this issue Mar 20, 2021 · 2 comments

Comments

@aulea
Copy link
Contributor

aulea commented Mar 20, 2021

  • Mark all Trait added methods as @Generated
  • Mark all AST transformation added methods/constructions/classes as @Generated

Then example Jacoco could create better code coverage reports.

Origin issue grails/grails-core#11318
@aulea
Copy link
Contributor Author

aulea commented Mar 22, 2021

@puneetbehl Is it also possible to upgrade groovy version in this project to 2.5.14 (as is also grails-core)? Some time ago created also pull-request about it, when it suits #1420

aulea added a commit to aulea/grails-data-mapping that referenced this issue Aug 3, 2021
@aulea
Issue grails#1445 apply Generated annotation to Traits, to improve te…
aea4293 
…st coverage reports
aulea added a commit to aulea/grails-data-mapping that referenced this issue Aug 3, 2021
@aulea
Issue grails#1445 apply Generated annotation to methods/constructors …
d695f4a 
…created with AST transformation, to improve test coverage reports
@aulea aulea mentioned this issue Aug 3, 2021
Merged
@boardbloke boardbloke mentioned this issue Oct 28, 2021
Open
@andersaaberg
Copy link

Please include this in Grails 5, as we cannot use OpenClover in Grails 5 and Jacoco coverage is currently very bad compared to OpenClover in Grails 4.

puneetbehl pushed a commit that referenced this issue Feb 1, 2022
@aulea
Issue 1445 apply generated annotation (#1507)
ed6d474 
* Issue #1445 apply Generated annotation to Traits, to improve test coverage reports

* Issue #1445 apply Generated annotation to methods/constructors created with AST transformation, to improve test coverage reports

Co-authored-by: Alar Aule <[email protected]>
@boardbloke boardbloke mentioned this issue Jun 17, 2022
Open
@boardbloke boardbloke mentioned this issue Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aulea @andersaaberg