Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multipleDatasources.adoc #888

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

kovacicluka
Copy link
Contributor

As in org.grails.plugins.datasource.DataSourceGrailsPlugin, configuration name is grails.transaction.chainedTransactionManager.

As in org.grails.plugins.datasource.DataSourceGrailsPlugin, configuration name is `grails.transaction.chainedTransactionManager`.
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

@puneetbehl
Copy link
Contributor

Please sign the CLA.

@kovacicluka
Copy link
Contributor Author

Please sign the CLA.

I did, when I clicked again on "CLA not signed yet" I got "You have agreed to the CLA for grails/grails-doc"

matrei
matrei previously requested changes Aug 11, 2024
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! There are actually two more places where chainedTransactionManagerPostProcessor should be changed.

You can enable Grails to use the Best Effort 1PC pattern for handling transactions across multiple datasources. To do so you must set the `grails.transaction.chainedTransactionManagerPostProcessor.enabled` setting to `true` in `application.yml`:

chainedTransactionManagerPostProcessor:

Would you mind changing these as well in this PR?

@grails grails deleted a comment from CLAassistant Sep 6, 2024
@jamesfredley jamesfredley changed the base branch from 6.1.x to 7.0.x November 11, 2024 21:31
@jamesfredley jamesfredley changed the base branch from 7.0.x to 6.1.x November 11, 2024 21:31
@jamesfredley
Copy link
Contributor

I'll submit those other 2 changes in another PR.

@jamesfredley jamesfredley dismissed matrei’s stale review November 11, 2024 21:44

will submit other two changes in another PR

@jamesfredley
Copy link
Contributor

And then will merging branches up to 7.0.x

@jamesfredley jamesfredley merged commit 839b387 into grails:6.1.x Nov 11, 2024
1 of 2 checks passed
@jamesfredley
Copy link
Contributor

#916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants