chore(deps): Grails 7 grails-forge update JDK options to 17, 21 and 23 #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesfredley
changed the title
|
I'm thinking about how this would work in CI when running the tests, if we were to use a matrix for building and/or running the tests. Is there any value in running the tests in this project with 17, 21 and 23 and in that case is it feasible with generating the apps in the tests with |
|
If we put matrix java back in place that makes sense to exercise the different versions. I was worried about these tests failing locally if you happened to be on say Java 19 or 22, but that is pretty unlikely. |
…tingSystem) method
jamesfredley
changed the title
jamesfredley
changed the title
jamesfredley
changed the title
matrei
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaults to
System.getProperty("java.version")for tests.Adding Java 23 (same applies to 22) to matix.java will likely need to wait on #391
https://github.com/grails/grails-forge/pull/400/files#diff-4c087648fbb704b0cc106eebfff7779856a6af4a6987e919debdd3afd1fdf7bbR15
Grails 7 supports 23, but grails-forge does not yet
also