-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
javax to jakarta, groovy 4, spring framework 6 and spring boot 3 #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesfredley
changed the title
WIP: javax to jakarta, groovy 4, spring framework 6 and spring boot 3
javax to jakarta, groovy 4, spring framework 6 and spring boot 3
Sep 10, 2024
This commit fixes the problem with domain inheritance in Groovy 4 (for this example application)
Needed for `grails.util.GrailsMessageSourceUtils` to be resolved.
- MapRenderSpec - NullRenderingSpec
@matrei Would you be OK merging this PR to publish an updated 4.0.0-SNAPSHOT that is needed by several other projects and then continue working on the issues in another branch? |
@jamesfredley Absolutely! Go ahead and merge 👍 |
matrei
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Select the Grails messageSource when Micronaut creates a 2nd messageSource bean
In the current state we can get a snapshot published, which is needed for grails/grails-async#140 and then work on outstanding issues.
Requires the 5.0.1+ release of asset-pipeline https://central.sonatype.com/artifact/com.bertramlabs.plugins/asset-pipeline-grails
Current Issues:
Issues added to #582