feat: Add support for new float syntax #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
reviewed
Feb 29, 2024
| @@ -838,6 +838,15 @@ | |||
| } | |||
| } | |||
| }, | |||
| { | |||
| "match": "\\b(0[xX][\\da-fA-F]+)(\\.[\\da-fA-F]*)?([p`P][+-]?\\d[\\d_]*)?([fdwW]?)\\b", | |||
There was a problem hiding this comment.
Why is there a backtick in [p`P]?
There was a problem hiding this comment.
Also looks like underscores aren't accepted in the mantissa.
There was a problem hiding this comment.
I think we accept it in our implementation.
There was a problem hiding this comment.
Yes, I meant that the underscores weren't accepted by your regex here. I'll add them.
ospencer
reviewed
Mar 4, 2024
|
ospencer
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally closed my other pr, when I deleted my fork, reopening from my new fork.
Closes: #154