Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): Add Language Status Item #179

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

spotandjake
Copy link
Member

This adds a languageStatusItem to the vscode extension VSCODE Status Item specifically this provides a place for us to list the grain extension commands and display stats about the server.

This pr also contributes a new openOutput command which opens the grain extension output window.

The statusBar item currently only shows an error severity when the lsp crashes out. But we can extend the functionality in the future similar to how rescript tracks status here and have it show things such as if the lsp is busy during formatting.
image

@spotandjake spotandjake added the enhancement New feature or request label Oct 24, 2024
@spotandjake spotandjake self-assigned this Oct 24, 2024
@ospencer
Copy link
Member

Do we really need a command to show the output? That feels like something just for people developing the LSP rather than the average user.

@spotandjake
Copy link
Member Author

Do we really need a command to show the output? That feels like something just for people developing the LSP rather than the average user.

It mostly is useful for when developing but I was going off what the eslint extension had in their status item and given its a place that shows the current lsp status such as if it is not working I think it makes sense for the logs to be easily accessible from it.

Screenshot 2024-11-21 at 11 09 42 AM

@ospencer ospencer merged commit a02dd63 into grain-lang:main Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants