Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): Add run button #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spotandjake
Copy link
Member

This pr adds a run current file button with a corresponding configuration and command.
Screenshot 2024-10-24 at 3 00 31 PM
It currently uses the runCommandLayout configuration to build a pattern and then opens the terminal with the run command when pressed.

Closes: #167

@spotandjake spotandjake added the enhancement New feature or request label Oct 24, 2024
@spotandjake spotandjake self-assigned this Oct 24, 2024
@ospencer
Copy link
Member

I feel like if we add this it needs to be configurable in some way. There's a lot of cases where it's handy to just run a file (especially for tests), but if you're targeting anything other than the command line this button will just result in an error.

I'm not super against just merging it as-is, but curious to what your thoughts are.

@spotandjake
Copy link
Member Author

spotandjake commented Nov 21, 2024

In general I 100% agree with you however I think that is probably in the scope of silo and something that will be configured in your silo.toml file once it exists, for now I just made the run button open the default run command in your terminal, the user can edit it if they want and just press enter to run the program. Letting silo handle this will also make it less editor specific reducing work when supporting us editors.

@ospencer
Copy link
Member

Sure. I do think though that the run button should just run the code, it shouldn't give me a command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile button
2 participants