[LibOS] chroot fs: remove redundant arg in chroot_temp_open()

[dimakuv]

Description of the changes

As in title. Tiny change.

Extracted from #1812.

How to test this PR?

N/A.

---

This change is 

[kailun-qin]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)

a discussion (no related file):
What about

gramine/libos/src/fs/shm/fs.c

Line 55 in 0ee48ee

static int shm_do_open(struct libos_handle* hdl, struct libos_dentry* dent, mode_t type,

?

---

[dimakuv]

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @kailun-qin)

a discussion (no related file):

Previously, kailun-qin (Kailun Qin) wrote…

What about

gramine/libos/src/fs/shm/fs.c

Line 55 in 0ee48ee

static int shm_do_open(struct libos_handle* hdl, struct libos_dentry* dent, mode_t type,

?

That's different. In the _do_open() functions we can't remove the type argument.

Please note that we have a similar function here, chroot_do_open(), where I also do not remove the type argument.

---

[dimakuv]

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @kailun-qin)

a discussion (no related file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

That's different. In the _do_open() functions we can't remove the type argument.

Please note that we have a similar function here, chroot_do_open(), where I also do not remove the type argument.

An additional explanation that may help understand the difference:

• chroot_temp_open() is used to open a definitely-existing file, just to get a handle on this file. This is needed because many PAL functions operate only on opened handles, not on filenames.
• chroot_do_open() is used to open or create a file, getting the handle on this file as a by-effect. Since the file may not exist (thus there is no inode to extract the info from), we need to know the type explicitly.

shm_do_open() is related to the second kind of helper functions. So not applicable to this PR.

---

[kailun-qin]

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from different teams (1 more required, approved so far: Intel)

a discussion (no related file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

An additional explanation that may help understand the difference:

• chroot_temp_open() is used to open a definitely-existing file, just to get a handle on this file. This is needed because many PAL functions operate only on opened handles, not on filenames.
• chroot_do_open() is used to open or create a file, getting the handle on this file as a by-effect. Since the file may not exist (thus there is no inode to extract the info from), we need to know the type explicitly.

shm_do_open() is related to the second kind of helper functions. So not applicable to this PR.

Indeed -- I misread it. Thanks for the great explanation!

---

[mkow]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[mkow]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[dimakuv]

Jenkins, retest this please (unrelated Jenkins maintenance issues)

[kailun-qin]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[dimakuv]

Jenkins, retest this please (unrelated Jenkins maintenance issues)