[LibOS] Rename chroot_dentry_uri() into dentry_uri()
#1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakuv
commented
Mar 14, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
libos/src/fs/libos_dcache.c line 345 at r1 (raw file):
} static const char* strip_prefix(const char* uri) {
All this code is a direct copy-paste from another file.
mkow
previously approved these changes
May 5, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Function `chroot_dentry_uri()` is a generic function to extract the URI out of the dentry (by concatenating the URI prefix, the dentry's mount point path and the dentry relative name). Thus this function must have a generic name and must be moved to a generic dentry file. Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
mkow
force-pushed
the
dimakuv/rename-chroot-dentry-uri
branch
from
fbf1764 to
46491d5
Compare
mkow
approved these changes
May 5, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Function
chroot_dentry_uri()is a generic function to extract the URI out of the dentry (by concatenating the URI prefix, the dentry's mount point path and the dentry relative name). Thus this function must have a generic name and must be moved to a generic dentry file.Extracted from #1812.
How to test this PR?
N/A.
This change is