[LibOS] test/regression: reenable sigaltstack test
#1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakuv
force-pushed
the
dimakuv/reenable-sigaltstack-test
branch
from
9fca996 to
a631ea3
Compare
mkow
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
kailun-qin
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
There was a small bug in the test itself, which is fixed (sigaltstack size must be sufficiently large to hold the Gramine-generated frame). Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
mkow
force-pushed
the
dimakuv/reenable-sigaltstack-test
branch
from
a631ea3 to
0ee48ee
Compare
mkow
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
kailun-qin
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
As in title. I don't know/remember why the test was disabled, but everything works on current Gramine master. So looks like we just forgot to re-enable this test when refactoring signaling code.
Extracted from #1812 (completely unrelated, just noticed while working on that PR).
How to test this PR?
CI.
This change is