Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LibOS] Add /dev/fd/ directory #1873

Merged
merged 1 commit into from
May 9, 2024
Merged

[LibOS] Add /dev/fd/ directory #1873

merged 1 commit into from
May 9, 2024

Conversation

mkow
Copy link
Member

@mkow mkow commented May 7, 2024

Description of the changes

Fixes #1267 (or at least one of the problems there, I split out the other problem to #1872).

How to test this PR?

Try ls -la <(echo 123) in Bash under Gramine.


This change is Reviewable

Copy link

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Copy link

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @mkow)

a discussion (no related file):
You sure you want to mention that it fixes #1267? It doesn't really (it kinda fixes the title, but it doesn't fix the actual problem of reading the pipe that is explained in the issue).


Copy link
Member Author

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)

a discussion (no related file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

You sure you want to mention that it fixes #1267? It doesn't really (it kinda fixes the title, but it doesn't fix the actual problem of reading the pipe that is explained in the issue).

Yeah, I prefer to close that one because it's a bit messy. That's why I created #1872, which is cleaner and lists exactly what's left to do.


Copy link

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

a discussion (no related file):

Previously, mkow (Michał Kowalczyk) wrote…

Yeah, I prefer to close that one because it's a bit messy. That's why I created #1872, which is cleaner and lists exactly what's left to do.

Ok, fair enough.


Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Signed-off-by: Michał Kowalczyk <[email protected]>
@mkow mkow force-pushed the mkow/add-dev-fd branch from 8ab576a to 25056d0 Compare May 9, 2024 13:35
Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mkow mkow merged commit 25056d0 into master May 9, 2024
18 of 20 checks passed
@mkow mkow deleted the mkow/add-dev-fd branch May 9, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/dev/fd/ support
3 participants