Ubuntu 24.04 LTS (noble) part 2

[woju]

Description of the changes

Fixes: #1893

How to test this PR?

CI

---

This change is 

[woju]

Jenkins, test this please

[dimakuv]

Reviewed 4 of 8 files at r1, 16 of 16 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, 1 of 1 files at r10, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)

---

.ci/linux-sgx-ubuntu24.04-edmm.jenkinsfile line 12 at r6 (raw file):

    env.DOCKER_ARGS_SGX += '''
        --add-host host.docker.internal:host-gateway

Is this something new? Why it is needed?

[woju]

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)

---

.ci/linux-sgx-ubuntu24.04-edmm.jenkinsfile line 12 at r6 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Is this something new? Why it is needed?

This is copied from 20.04 EDMM pipeline. I don't know why it's there, git blame says it was added by Borys.

[dimakuv]

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)

---

.ci/linux-sgx-ubuntu24.04-edmm.jenkinsfile line 12 at r6 (raw file):

Previously, woju (Wojtek Porczyk) wrote…

This is copied from 20.04 EDMM pipeline. I don't know why it's there, git blame says it was added by Borys.

So it was added in this commit: 1b1242f

I'm fairly certain that it's because that particular host (where this pipeline ran) had a PCCS daemon running on the host, and this needed this Docker-host-gateway trick. See the .ci/ubuntu20.04.dockerfile in that commit.

I don't see that you install or enable PCCS in any way in the Ubuntu 24.04 Dockerfile: https://github.com/gramineproject/gramine/blob/woju/ubuntu-noble-2/.ci/ubuntu24.04.dockerfile. So I guess the tests that try DCAP-based SGX remote attestation fail right now?

[mkow]

Reviewable status: 18 of 30 files reviewed, 3 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv and @woju)

---

-- commits line 2 at r21:
Could you move this out into a separate PR? It's a trivial refactoring and we could merge it right away.

---

-- commits line 61 at r21:
Please squash all these commits in the final version of the PR.

[woju]

Reviewable status: 18 of 30 files reviewed, 3 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv, @mkow, and @woju)

---

-- commits line 2 at r21:

Previously, mkow (Michał Kowalczyk) wrote…

Could you move this out into a separate PR? It's a trivial refactoring and we could merge it right away.

#1920, feel free to merge ad libitum, however once you merge, I'll have to rebase this PR on top of new master.

---

-- commits line 61 at r21:

Previously, mkow (Michał Kowalczyk) wrote…

Please squash all these commits in the final version of the PR.

Will do, after I finish all the stuff here, for now it's more convenient for me to keep separate commits for now. Please keep blocking.

---

.ci/linux-sgx-ubuntu24.04-edmm.jenkinsfile line 12 at r6 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

So it was added in this commit: 1b1242f

I'm fairly certain that it's because that particular host (where this pipeline ran) had a PCCS daemon running on the host, and this needed this Docker-host-gateway trick. See the .ci/ubuntu20.04.dockerfile in that commit.

I don't see that you install or enable PCCS in any way in the Ubuntu 24.04 Dockerfile: https://github.com/gramineproject/gramine/blob/woju/ubuntu-noble-2/.ci/ubuntu24.04.dockerfile. So I guess the tests that try DCAP-based SGX remote attestation fail right now?

That's right, they fail with error 44. I need to fix that stuff before we merge.

[dimakuv]

Reviewable status: 18 of 30 files reviewed, 4 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @mkow and @woju)

a discussion (no related file):
This PR looks like it's still work in progress. I won't review it now then.

---

---

-- commits line 2 at r21:

Previously, woju (Wojtek Porczyk) wrote…

#1920, feel free to merge ad libitum, however once you merge, I'll have to rebase this PR on top of new master.

#1920 was merged

[woju]

Jenkins, test this please

[woju]

Jenkins, test this please

[woju]

Superseded by #2021 and #2026 to #2031.