-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Installation docs for 1.8 #1993
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
a discussion (no related file):
I'm blocking merging this PR until Intel publishes noble
repo at https://download.01.org/intel-sgx/sgx_repo/ubuntu/
(check the subdirectory in https://download.01.org/intel-sgx/sgx_repo/ubuntu/dists/).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
-- commits
line 2 at r1:
We typically add v
before the version.
-- commits
line 5 at r1:
Backticks around this code snippet?
Since apt 2.4, the distro provides /etc/apt/keyrings for user-managed package signing keys and /usr/share/keyrings is recommended for use with keys managed by packages. Debian 11 has older apt, so the directory is not present in the system. I'll leave it as is, instead of adding `mkdir -p`. Signed-off-by: Wojtek Porczyk <[email protected]>
Signing keys were rotated, but only for new distributions, hence 3 extra $(lsb_release -sc). Signed-off-by: Wojtek Porczyk <[email protected]>
dc7a0c8
to
6fec2d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
-- commits
line 10 at r2:
We never use I will leave...
, instead we write This commit leaves...
Description of the changes
Because keys for new distros were rotated, the download paths got extra
$(lsb_release -sc)
.No change for RPM, because there's no
.el10
repo.How to test this PR?
Install (for
noble
, useunstable-
for gramine repo, andmantic
for intel's repo).This change is