Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 mig fiscal company account #57

Merged

Conversation

legalsylvain
Copy link
Member

No description provided.

@legalsylvain legalsylvain force-pushed the 16.0-mig-fiscal_company_account branch from 183e972 to 1dc87ea Compare August 6, 2024 22:06
@legalsylvain legalsylvain marked this pull request as ready for review August 8, 2024 09:39
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 86.40351% with 31 lines in your changes missing coverage. Please review.

Project coverage is 90.80%. Comparing base (47b8b93) to head (09d0072).
Report is 3 commits behind head on 16.0.

Files Patch % Lines
fiscal_company_account/models/account_journal.py 36.36% 14 Missing ⚠️
fiscal_company_account/models/account_move.py 63.15% 7 Missing ⚠️
...ompany_account/tests/test_mixin_change_filtered.py 84.61% 0 Missing and 4 partials ⚠️
...odels/fiscal_company_change_search_domain_mixin.py 0.00% 3 Missing ⚠️
fiscal_company_account/models/account_account.py 75.00% 1 Missing and 1 partial ⚠️
...tests/test_fiscal_company_change_filtered_mixin.py 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0      #57      +/-   ##
==========================================
- Coverage   92.85%   90.80%   -2.05%     
==========================================
  Files           9       30      +21     
  Lines         182      446     +264     
  Branches       42       72      +30     
==========================================
+ Hits          169      405     +236     
- Misses          7       30      +23     
- Partials        6       11       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legalsylvain legalsylvain force-pushed the 16.0-mig-fiscal_company_account branch 3 times, most recently from 155b65f to 79f867d Compare August 8, 2024 12:34
@legalsylvain
Copy link
Member Author

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-57-by-legalsylvain-bump-minor, awaiting test results.

github-grap-bot added a commit that referenced this pull request Aug 8, 2024
Signed-off-by legalsylvain
@github-grap-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-57-by-legalsylvain-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

- allow to disable 'with_company' call in odoo, with the key in the context
- adapt code to V16
- remove useless (and not working) code to propagate properties
- move abstract into fiscal_company_base (adding tests)
- restore (partially) disabled accounting dashboard
@legalsylvain legalsylvain force-pushed the 16.0-mig-fiscal_company_account branch from 79f867d to 117f48d Compare August 8, 2024 13:13
@legalsylvain
Copy link
Member Author

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-57-by-legalsylvain-bump-minor, awaiting test results.

@github-grap-bot github-grap-bot merged commit cdc2517 into grap:16.0 Aug 8, 2024
2 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at dea3b20. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants