This repository has been archived by the owner on Mar 1, 2021. It is now read-only.
WIP: handling viterbi breaks as multiple sequences #87
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,80 @@ | ||
| /* | ||
| * Licensed to GraphHopper GmbH under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with this work for | ||
| * additional information regarding copyright ownership. | ||
| * | ||
| * GraphHopper GmbH licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except in | ||
| * compliance with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.graphhopper.matching; | ||
|
|
||
| import com.graphhopper.util.EdgeIteratorState; | ||
| import com.graphhopper.util.GPXEntry; | ||
| import com.graphhopper.util.shapes.GHPoint3D; | ||
|
|
||
| public class MatchEntry { | ||
| public static enum MatchState { MATCHING_NOT_STARTED, NOT_USED_FOR_MATCHING, MATCHED }; | ||
| private MatchState matchState = MatchState.MATCHING_NOT_STARTED; | ||
| public final GPXEntry gpxEntry; | ||
| private int sequenceIdx; | ||
| private GHPoint3D snappedPoint; | ||
| private EdgeIteratorState directedRealEdge; | ||
| private int sequenceMatchEdgeIdx; | ||
| private double distanceAlongRealEdge; | ||
| private boolean locked = false; | ||
|
|
||
| protected MatchEntry(GPXEntry gpxEntry) { | ||
| this.gpxEntry = gpxEntry; | ||
| } | ||
|
|
||
| protected void markAsNotUsedForMatching() { | ||
| assert !locked; | ||
| this.matchState = MatchState.NOT_USED_FOR_MATCHING; | ||
| locked = true; | ||
| } | ||
|
|
||
| protected void saveMatchingState(int sequenceIdx, int sequenceMatchEdgeIdx, | ||
|
There was a problem hiding this comment. The method is called externally (e.g. here) and I don't want it to be available to users - I could be missing something, but isn't this the purpose of 'protected'? There was a problem hiding this comment. In this case you should use package-private (no modifier) instead of protected. Protected should only be used if you plan to access the method in derived classes. There was a problem hiding this comment. Sorry about that, and thanks for pointing it out. |
||
| EdgeIteratorState directedRealEdge, double distanceAlongRealEdge, | ||
| GHPoint3D snappedPoint) { | ||
| assert !locked; | ||
| this.sequenceIdx = sequenceIdx; | ||
| this.sequenceMatchEdgeIdx = sequenceMatchEdgeIdx; | ||
| this.directedRealEdge = directedRealEdge; | ||
| this.distanceAlongRealEdge = distanceAlongRealEdge; | ||
| this.snappedPoint = snappedPoint; | ||
| locked = true; | ||
| } | ||
|
|
||
| public MatchState getMatchState() { | ||
| return matchState; | ||
| } | ||
|
|
||
| public int getSequenceIdx() { | ||
| return sequenceIdx; | ||
| } | ||
|
|
||
| public GHPoint3D getSnappedPoint() { | ||
| return snappedPoint; | ||
| } | ||
|
|
||
| public EdgeIteratorState getDirectedRealEdge() { | ||
| return directedRealEdge; | ||
| } | ||
|
|
||
| public int getSequenceMatchEdgeIdx() { | ||
| return sequenceMatchEdgeIdx; | ||
| } | ||
|
|
||
| public double getDistanceAlongRealEdge() { | ||
| return distanceAlongRealEdge; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this protected, do you plan to inherit from this class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.