Explicit comparison

graphile · Apr 29, 2024 · 60eb1d2 · 60eb1d2
1 parent 5690546
commit 60eb1d2
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/grafast/grafast/src/engine/executeBucket.ts b/grafast/grafast/src/engine/executeBucket.ts
@@ -603,7 +603,6 @@ export function executeBucket(
             let forceIndexValue: GrafastError | null | undefined = undefined;
             let rejectValue: GrafastError | null | undefined = undefined;
             let indexFlags: ExecutionEntryFlags = NO_FLAGS;
-            // for (const $dep of step.dependencies) {
             for (let i = 0, l = step.dependencies.length; i < l; i++) {
               const $dep = step.dependencies[i];
               const forbiddenFlags = step.dependencyForbiddenFlags[i];
@@ -622,7 +621,7 @@ export function executeBucket(
                 // If dep is inhibited and we do allow inhibited, but we're disallowed, use our onReject.
                 // If dep is not inhibited, but we're disallowed, use our onReject.
                 if (
-                  onReject &&
+                  onReject !== undefined &&
                   (disallowedFlags & (FLAG_INHIBITED | FLAG_ERROR)) === NO_FLAGS
                 ) {
                   rejectValue ||= onReject;
@@ -856,7 +855,7 @@ export function executeBucket(
             // If dep is inhibited and we do allow inhibited, but we're disallowed, use our onReject.
             // If dep is not inhibited, but we're disallowed, use our onReject.
             if (
-              onReject &&
+              onReject !== undefined &&
               (disallowedFlags & (FLAG_INHIBITED | FLAG_ERROR)) === NO_FLAGS
             ) {
               rejectValue ||= onReject;