Remove needless NO_FLAGS comparison

graphile · May 1, 2024 · e3663b6 · e3663b6
1 parent 1876827
commit e3663b6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/grafast/grafast/src/engine/LayerPlan.ts b/grafast/grafast/src/engine/LayerPlan.ts
@@ -11,7 +11,6 @@ import {
   FLAG_INHIBITED,
   FLAG_NULL,
   FORBIDDEN_BY_NULLABLE_BOUNDARY_FLAGS,
-  NO_FLAGS,
 } from "../interfaces.js";
 import { resolveType } from "../polymorphic.js";
 import type {
@@ -410,7 +409,7 @@ export class LayerPlan<TReason extends LayerPlanReason = LayerPlanReason> {
           )! as UnaryExecutionValue;
           const forbiddenFlags =
             fieldValue._entryFlags & FORBIDDEN_BY_NULLABLE_BOUNDARY_FLAGS;
-          if (forbiddenFlags !== NO_FLAGS) {
+          if (forbiddenFlags) {
             size = 0;
           } else {
             size = parentBucket.size;
@@ -628,10 +627,7 @@ export class LayerPlan<TReason extends LayerPlanReason = LayerPlanReason> {
           originalIndex++
         ) {
           const flags = polymorphicPlanStore._flagsAt(originalIndex);
-          if (
-            (flags & (FLAG_ERROR | FLAG_INHIBITED | FLAG_NULL)) !==
-            NO_FLAGS
-          ) {
+          if (flags & (FLAG_ERROR | FLAG_INHIBITED | FLAG_NULL)) {
             continue;
           }
           const value = polymorphicPlanStore.at(originalIndex);

diff --git a/grafast/grafast/src/engine/executeBucket.ts b/grafast/grafast/src/engine/executeBucket.ts
@@ -593,7 +593,7 @@ export function executeBucket(
               // Search for "f2b3b1b3" for similar block
               const flags = depExecutionVal._flagsAt(dataIndex);
               const disallowedFlags = flags & forbiddenFlags;
-              if (disallowedFlags !== NO_FLAGS) {
+              if (disallowedFlags) {
                 indexFlags |= disallowedFlags;
                 // If there's a reject behavior and we're FRESHLY rejected (weren't
                 // already inhibited), use that as a fallback.
@@ -815,7 +815,7 @@ export function executeBucket(
       ) {
         indexFlags |= FLAG_POLY_SKIPPED;
         forceIndexValue = null;
-      } else if (extra._bucket.flagUnion !== NO_FLAGS) {
+      } else if (extra._bucket.flagUnion) {
         for (
           let i = 0, l = dependenciesIncludingSideEffects.length;
           i < l;
@@ -828,7 +828,7 @@ export function executeBucket(
           // Search for "f2b3b1b3" for similar block
           const flags = depExecutionVal._flagsAt(dataIndex);
           const disallowedFlags = flags & forbiddenFlags;
-          if (disallowedFlags !== NO_FLAGS) {
+          if (disallowedFlags) {
             indexFlags |= disallowedFlags;
             // If there's a reject behavior and we're FRESHLY rejected (weren't
             // already inhibited), use that as a fallback.