Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add withPgClient import in docs #2057

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

MarioSimou
Copy link
Contributor

Description

Update withPgClient example to include the necessary imports.

Performance impact

None

Security impact

None

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: f5d2ddd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since this is in the grafast.org website it can't refer to the postgraphile/@dataplan/pg import (Grafast doesn't "know" about PostGraphile), but you should definitely use the postgraphile/@dataplan/pg path in your own projects to avoid duplicate module issues. You can also access it from build.dataplanPg.withPgClient which is the preferred way.

@benjie benjie merged commit 91a2ab6 into graphile:main May 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants