Improve startBlock validation

graphprotocol · Nov 29, 2024 · a6e830d · a6e830d
1 parent 4032c83
commit a6e830d
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/packages/cli/src/commands/add.ts b/packages/cli/src/commands/add.ts
@@ -81,7 +81,7 @@ export default class AddCommand extends Command {
 
     if (isLocalHost) this.warn('`localhost` network detected, prompting user for inputs');
 
-    let startBlock = startBlockFlag;
+    let startBlock = parseInt(startBlockFlag ?? '').toString();
     let contractName = contractNameFlag;
 
     const entities = getEntities(manifest);
@@ -136,9 +136,7 @@ export default class AddCommand extends Command {
 
     try {
       if (isLocalHost) throw Error; // Triggers user prompting without waiting for Etherscan lookup to fail
-      if (startBlock === undefined) {
-        startBlock = Number(await loadStartBlockForContract(network, address)).toString();
-      }
+      startBlock ||= Number(await loadStartBlockForContract(network, address)).toString();
     } catch (error) {
       // we cannot ask user to do prompt in test environment
       if (process.env.NODE_ENV !== 'test') {
@@ -161,7 +159,6 @@ export default class AddCommand extends Command {
 
     try {
       if (isLocalHost) throw Error; // Triggers user prompting without waiting for Etherscan lookup to fail
-
       contractName ||= await loadContractNameForAddress(network, address);
     } catch (error) {
       // not asking user to do prompt in test environment