feat: integrate matchstick into the graph CLI #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cf29a94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey, you'll also need to integrate matchstick-as as well, which is a helper library similar to |
Deploying graph-tooling with
|
| Latest commit: |
cf29a94
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://da203ca1.graph-tooling.pages.dev |
| Branch Preview URL: | https://add-matchstick.graph-tooling.pages.dev |
saihaj
reviewed
May 1, 2024
saihaj
reviewed
May 1, 2024
YassinEldeeb
force-pushed
the
add-matchstick
branch
from
fb76495
to
8c543eb
Compare
saihaj
reviewed
Jul 23, 2024
| } = await this.parse(TestCommand); | ||
|
|
||
| // Ensure PostgreSQL 14 is installed | ||
| try { |
saihaj
reviewed
Jul 23, 2024
.changeset/slow-pears-agree.md
Outdated
There was a problem hiding this comment.
let's update this to real message
saihaj
reviewed
Jul 23, 2024
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
|
|
||
| # CLI |
There was a problem hiding this comment.
uncomment now so we can prep to merge?
saihaj
reviewed
Jul 23, 2024
packages/cli/package.json
Outdated
| @@ -29,12 +29,12 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@float-capital/float-subgraph-uncrashable": "^0.0.0-alpha.4", | |||
| "@graphprotocol/graph-tooling-napi-utils": "workspace:*", | |||
There was a problem hiding this comment.
the issue we are facing now is even for test suite we have to build otherwise it will fail 🤔
There was a problem hiding this comment.
yeah, but we build it in the CI, maybe locally we should pre-build before testing too
saihaj
reviewed
Jul 23, 2024
packages/napi-utils/Cargo.toml
Outdated
| @@ -0,0 +1,43 @@ | |||
| [package] | |||
| name = "matchstick" | |||
saihaj
reviewed
Jul 23, 2024
saihaj
reviewed
Jul 23, 2024
Comment on lines
+39
to
+43
| # - host: windows-latest | ||
| # target: i686-pc-windows-msvc | ||
| # build: | | ||
| # rustup target add i686-pc-windows-msvc | ||
| # pnpm build --target i686-pc-windows-msvc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.