Support parsing full path contract name from block explorers #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87e1334 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like there are issues with openzeppelin contracts, i.e. 
|
|
@YaroShkvorets Good catch thanks, I've simplified the regex 👍 |
In case name of the file doesn't match the actual contract name, the regex would not be valid. Instead, we just pick the contract name following colon.
|
Simplified further without regex for cases like Not sure if it's even possible but we don't know what the explorer can return so to be safe, this just takes whatever is after the last colon ( |
YaroShkvorets
approved these changes
Nov 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some explorers like ZkSync will return the
ContractNamewith a full path like so:{ ... "ContractName": "contracts/SyncSwapRouter.sol:SyncSwapRouter", ... }This PR adds support for parsing the contract name for this format (e.g.
SyncSwapRouter).