Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tap, toolshed and ethers dependencies #105

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

Jannis
Copy link
Collaborator

@Jannis Jannis commented Dec 1, 2023

This bumps a number of important dependencies.

@Jannis Jannis requested a review from aasseman December 1, 2023 22:24
@aasseman
Copy link
Contributor

aasseman commented Dec 1, 2023

Adding the arbitrary-precision feature to serde will fix the test.
Don't know why it wasn't a problem before 🤷 .

@Jannis
Copy link
Collaborator Author

Jannis commented Dec 1, 2023

Adding the arbitrary-precision feature to serde will fix the test. Don't know why it wasn't a problem before 🤷 .

@aasseman That did the trick indeed!

Copy link

github-actions bot commented Dec 1, 2023

Pull Request Test Coverage Report for Build 7065875167

  • 24 of 35 (68.57%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 59.157%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/attestations/dispute_manager.rs 1 3 33.33%
common/src/escrow_accounts.rs 1 3 33.33%
common/src/subgraph_client/monitor.rs 3 5 60.0%
service/src/server/routes/network.rs 0 2 0.0%
common/src/allocations/monitor.rs 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
tap-agent/src/tap/sender_allocation_relationship.rs 1 84.15%
Totals Coverage Status
Change from base Build 6868912986: 0.2%
Covered Lines: 2413
Relevant Lines: 4079

💛 - Coveralls

@Jannis Jannis merged commit 00b4683 into main Dec 1, 2023
5 checks passed
@Jannis Jannis deleted the jannis/update-tap branch December 1, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants