fix: support sender signers #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasseman
added
size:large
Pull Request Test Coverage Report for Build 7548678988Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Signed-off-by: Alexis Asseman <[email protected]>
aasseman
force-pushed
the
aasseman/signers_support
branch
from
a7da3f9
to
f8bca98
Compare
gusinacio
requested changes
Jan 15, 2024
Signed-off-by: Alexis Asseman <[email protected]>
Signed-off-by: Alexis Asseman <[email protected]>
Signed-off-by: Alexis Asseman <[email protected]>
gusinacio
requested changes
Jan 15, 2024
Signed-off-by: Alexis Asseman <[email protected]>
gusinacio
reviewed
Jan 16, 2024
Signed-off-by: Alexis Asseman <[email protected]>
aasseman
added a commit
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Alexis Asseman <[email protected]>
aasseman
added a commit
that referenced
this pull request
Jan 23, 2024
* feat(indexer-service): Sender denylist indexer-service will reject all paid queries from denied senders. Denylist DB table updates are watched through PG notifications. Signed-off-by: Alexis Asseman <[email protected]> * refactor: cleaner sender_denylist_watcher shutdown Signed-off-by: Alexis Asseman <[email protected]> * refactor: remove unnecessary Arc on CancellationToken Signed-off-by: Alexis Asseman <[email protected]> * fix: proper signers support after #110 Signed-off-by: Alexis Asseman <[email protected]> --------- Signed-off-by: Alexis Asseman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TAP implementation was assuming that the receipts/RAVs are signed by the Sender (aka. Escrow account owner), but they are actually signed by one of the signers (a key specifically created only for signing receipts/RAVs in the sender's name).
A sender can have any number of valid/thawing/expired signers.
This makes the code even uglier... I hope that I can think of a cleaner architecture later.