Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common,service): make receipt_max_value u128 #230

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(common,service): make receipt_max_value u128 #230

merged 1 commit into from
Jul 1, 2024

Conversation

aasseman
Copy link
Contributor

Fixes #200

@aasseman aasseman requested a review from gusinacio June 27, 2024 23:16
@aasseman aasseman self-assigned this Jun 27, 2024
@aasseman
Copy link
Contributor Author

Rebased onto latest main

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9716570433

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.039%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/indexer_service/http/indexer_service.rs 0 1 0.0%
service/src/config.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 9716391780: 0.0%
Covered Lines: 3825
Relevant Lines: 5792
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9716570433

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.039%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/indexer_service/http/indexer_service.rs 0 1 0.0%
service/src/config.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 9716391780: 0.0%
Covered Lines: 3825
Relevant Lines: 5792
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9716570433

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.039%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/indexer_service/http/indexer_service.rs 0 1 0.0%
service/src/config.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 9716391780: 0.0%
Covered Lines: 3825
Relevant Lines: 5792
💛 - Coveralls

gusinacio
gusinacio approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit 5f1c4be into main Jul 1, 2024
10 checks passed
@aasseman aasseman deleted the aasseman/issue-200 branch July 1, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

Assignees

@aasseman aasseman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All GRT values should be u128 internally
2 participants
@aasseman @gusinacio