Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(common): disable integration test depending on the hosted service #237

Merged
merged 1 commit into from
Jun 28, 2024
Merged

chore(common): disable integration test depending on the hosted service #237

merged 1 commit into from
Jun 28, 2024

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Jun 28, 2024 •
edited
Loading

This integration test depends on the now "defunct" hosted service, so the test always fails.

I am disabling it until we find a solution to this dependency on the hosted service.

@LNSD LNSD requested review from aasseman and hopeyen June 28, 2024 09:36
@LNSD LNSD self-assigned this Jun 28, 2024
hopeyen
hopeyen approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, maybe we can add an api_key secret as a replacement

@aasseman
Copy link
Contributor

cool, maybe we can add an api_key secret as a replacement

We're working on it with the foundation.
@LNSD good idea to disable in the meantime. I was initially hoping to find a solution quicker.

@aasseman aasseman merged commit 4fec93e into main Jun 28, 2024
10 checks passed
@aasseman aasseman deleted the lnsd/chore-common-disable-failing-integration-test branch June 28, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopeyen hopeyen hopeyen approved these changes

@aasseman aasseman Awaiting requested review from aasseman

Assignees

@LNSD LNSD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LNSD @aasseman @hopeyen