Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk insert of failed receipts using query macro #327

Closed
wants to merge 4 commits into from

Conversation

taslimmuhammed
Copy link
Contributor

Fixes #273
I have tested the query using a local db, not the entire project, if possible please test it on your environment.

@gusinacio
Copy link
Collaborator

gusinacio commented Sep 26, 2024

Hello, could you run a few commands to make our CI happy?

cargo clippy --all-targets --all-features # for clippy
cargo fmt # for fmt
cargo sqlx prepare --workspace -- --all-targets # for SQL offline mode

Make sure to commit all changes to the repository.

@gusinacio gusinacio self-requested a review September 26, 2024 10:03
@taslimmuhammed
Copy link
Contributor Author

Sure, sorry for the trouble, it's my first time contributing to a large project

@taslimmuhammed
Copy link
Contributor Author

Also could you give me a good on how to test the whole project, I have been testing the queries on a local db in a diff code.

@gusinacio
Copy link
Collaborator

gusinacio commented Sep 26, 2024

Hey, no worries I'm here to guide you.

The service has a lot of dependencies and you probably won't be able to get to specific code paths.

We usually create tests using sqlx to check if the code works.

You can get some examples in the end of the file.

Then it's as simple as running cargo test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat.Req] Bulk insert of failed receipts
2 participants