Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the custom sample to .NET 5 #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

joemcbride
Copy link
Member

Includes fully updating to System.Text.Json.

@Shane32
Copy link
Member

Shane32 commented May 17, 2021

I noticed that the sample has changed from a code-first sample to a schema-first sample. Perhaps this does not matter if the purpose of the sample is to demonstrate setup with ASP.Net Core.

I would suggest that the repo readme file be updated to indicate that the sample is of ASP.Net Core 5 rather than 3.1 now.

It might also be better to leave the ASP.Net Core 3.1 sample in place and add another sample for ASP.Net Core 5. ASP.Net Core 3.1 is still the current LTS version. Alternatively, we might simply add comments where changes are required for one version or the other.

@joemcbride
Copy link
Member Author

I noticed that the sample has changed from a code-first sample to a schema-first sample. Perhaps this does not matter if the purpose of the sample is to demonstrate setup with ASP.Net Core.

Yeah I was realizing we didn't have any schema-first examples, so I thought it would be good to include some. But both would be helpful.

It might also be better to leave the ASP.Net Core 3.1 sample in place and add another sample for ASP.Net Core 5.

Agreed - this is a good idea, I will do this.

@sungam3r sungam3r added the enhancement New feature or request label Dec 8, 2021
@sungam3r
Copy link
Member

More conflicts after #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants