-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of Altair UI settings #1044
Allow configuration of Altair UI settings #1044
Conversation
Looks good. You’ll need to run the api tests so that the approval file is updated and CI tests pass. I assume you tested this PR and the changes work sufficiently for your needs? |
you
You mean I need to run tests locally from VS? |
Yes. It will update an approval file; just commit the changed file and push. |
@sungam3r Do you want to review? I'll merge/release tomorrow otherwise. |
Co-authored-by: Shane Krueger <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1044 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 44 44
Lines 2180 2180
Branches 367 367
=======================================
Hits 2037 2037
Misses 102 102
Partials 41 41 |
Add support for Altair UI settings