Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetRecursivelyReferencedUsedFragments and SkipNode #1143

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Aug 13, 2024

  • The AuthorizationVisitorBase.GetRecursivelyReferencedUsedFragments method has been removed as ValidationContext now provides a overload to GetRecursivelyReferencedFragments which will only return fragments in use by the specified operation.
  • The AuthorizationVisitorBase.SkipNode method has been removed as ValidationContext now provides a ShouldIncludeNode method.

See below PR which added both methods in the main project:

Note:

  • Unreferenced fragment testing is present within AuthorizationTests.UnusedFragmentsAreIgnored
  • Skip/ignore testing is present within AuthorizationTests.SkipInclude

@Shane32 Shane32 added this to the 8.0 milestone Aug 13, 2024
@Shane32 Shane32 self-assigned this Aug 13, 2024
@Shane32 Shane32 requested a review from gao-artur August 13, 2024 02:24
@Shane32 Shane32 changed the title Remove GetRecursivelyReferencedUsedFragments Remove GetRecursivelyReferencedUsedFragments and SkipNode Aug 13, 2024
docs/migration/migration8.md Outdated Show resolved Hide resolved
Co-authored-by: Artur Gordashnikov <[email protected]>
@Shane32 Shane32 merged commit df124cb into develop Aug 13, 2024
7 checks passed
@Shane32 Shane32 deleted the remove_recursive_fragment_visitor branch August 13, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants