-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KeepAliveMode and SupportedWebSocketSubProtocols options #1154
Conversation
src/Transports.AspNetCore/WebSockets/GraphQLWs/SubscriptionServer.cs
Dismissed
Show dismissed
Hide dismissed
src/Transports.AspNetCore/WebSockets/GraphQLWs/SubscriptionServer.cs
Dismissed
Show dismissed
Hide dismissed
src/Transports.AspNetCore/WebSockets/SubscriptionsTransportWs/SubscriptionServer.cs
Fixed
Show fixed
Hide fixed
617576b
to
2cad736
Compare
src/Transports.AspNetCore/WebSockets/GraphQLWs/SubscriptionServer.cs
Dismissed
Show dismissed
Hide dismissed
src/Transports.AspNetCore/WebSockets/SubscriptionsTransportWs/SubscriptionServer.cs
Dismissed
Show dismissed
Hide dismissed
[Obsolete($"Please use the {nameof(OnConnectionInitAsync)} and {nameof(OnKeepAliveLoopAsync)} methods instead. This method will be removed in a future version of this library.")] | ||
protected override Task OnConnectionInitAsync(OperationMessage message, bool smartKeepAlive) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code has been carefully crafted to be fully backwards compatible, just in case of the rare instance that someone derived from this class to customize behavior.
src/Transports.AspNetCore/WebSockets/GraphQLWs/SubscriptionServer.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1154 +/- ##
==========================================
- Coverage 90.88% 89.06% -1.82%
==========================================
Files 50 51 +1
Lines 2425 2543 +118
Branches 432 450 +18
==========================================
+ Hits 2204 2265 +61
- Misses 175 224 +49
- Partials 46 54 +8 ☔ View full report in Codecov by Sentry. |
Adds a 'secure' keep-alive mode where:
Reason:
Consider: