-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Reject
ion branching in warp
filters (#1177)
#1222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyranron
added
enhancement
Improvement of existing features or bugfix
k::integration
Related to integration with third-party libraries or systems
lib::warp
Related to `warp` crate integration
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
k::testing
Related to testing and/or automated tests
labels
Nov 21, 2023
tyranron
added
k::documentation
Related to project documentation
k::example
Related to usage examples
feature
New feature or request
labels
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of existing features or bugfix
feature
New feature or request
k::documentation
Related to project documentation
k::example
Related to usage examples
k::integration
Related to integration with third-party libraries or systems
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
k::testing
Related to testing and/or automated tests
lib::warp
Related to `warp` crate integration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1177
Synopsis
See #1177:
Solution
Seems like seanmonstar/warp#487 (comment) hits the exact issue we have here:So, we should replaceor()
filters branching withor_else()
one.See #1177 (comment):
make_graphql_filter
to executecontext_extractor
only once.context_extractor
and mention rejection issue in API docs.query
,body
andjson
filters used insidemake_graphql_filter
requirerecover()
ing handle into hard errors.Checklist