Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom_types config parameter #36

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Add custom_types config parameter #36

merged 3 commits into from
Sep 20, 2023

Conversation

hugoShaka
Copy link
Contributor

Adds a custom_type configuration knob used by the PR gravitational/teleport-plugins#916

This allows to override types without specifying "gogoproto.customtype" (we don't use gogoproto anymore for the new types).

@hugoShaka hugoShaka mentioned this pull request Sep 19, 2023
Merged
marcoandredinis
marcoandredinis reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@marcoandredinis marcoandredinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should increment the version before actually merging the PR and require that version on teleport-plugins repo.

field_build_context.go Show resolved Hide resolved
@hugoShaka hugoShaka merged commit 71ade4d into main Sep 20, 2023
@hugoShaka hugoShaka deleted the hugo/add-custom-type-config branch September 20, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoandredinis marcoandredinis marcoandredinis approved these changes

@r0mant r0mant r0mant approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas klizhentas is a code owner

@russjones russjones Awaiting requested review from russjones russjones is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugoShaka @r0mant @marcoandredinis