This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
use the new bot API while keeping a similar behaviour #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
tcsc,
zmb3,
camscale and
fheinecke
as code owners
hugoShaka
commented
Apr 3, 2024
| Sensitive: true, | ||
| Description: "The bot joining token. If unset, a new random token is created and its name returned, otherwise a preexisting Bot token may be provided for IAM/OIDC joining.", |
There was a problem hiding this comment.
Note: this description was wrong, it's not possible to unset the token in the TF provider.
strideynet
approved these changes
Apr 3, 2024
r0mant
approved these changes
Apr 3, 2024
marcoandredinis
approved these changes
Apr 3, 2024
marcoandredinis
force-pushed
the
hugo/fix-bot-rpc
branch
from
7c90cd4 to
788a5a5
Compare
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the old CreateBot RPC on master, the provider doesn't compile anymore.
This PR is a quick fix: it uses the new RPC to create the bot. The long term fix is doing a breaking change and using the new bot resource correctly (generating from protobuf/go structs instead of writing the provider manually).
I need the Terraform provider to compile on master because I want to copy it there to get rid of the
teleport-pluginsrepo.