This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Drop swallow of trace.BadParameter errors in SearchEvents
#1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
tcsc,
zmb3,
camscale and
fheinecke
as code owners
strideynet
approved these changes
May 3, 2024
This PR removes a temporary error masking that causes troubles if the auth server returns a `trace.BadParameter` error if any parameter is incorrect. This error is no longer required because both server and event-handler already support the new unstructured events endpoints. Signed-off-by: Tiago Silva <[email protected]>
tigrato
force-pushed
the
tigrato/remove-error-swallow
branch
from
9a7abc3 to
a1faad7
Compare
r0mant
approved these changes
May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a temporary error masking that causes troubles if the auth server returns a
trace.BadParametererror if any parameter is incorrect. This error is no longer required because both server and event-handler already support the new unstructured events endpoints.