Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

ci: Combine linux and darwin tag pipelines #922

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

camscale
Copy link
Contributor

@camscale camscale commented Sep 21, 2023

Combine the pipelines for tag builds of linux and darwin builds of the
terraform provider and event-handler. These are pure Go programs so can
easily be cross-compiled using GOOS/GOARCH. The "tricky" part is the
universal binary, solved by using https://github.com/konoui/lipo - a Go
version of lipo (the tool that constructs universal binaries) that can
run on Linux.

This removes Apple Mac machines from the release pipeline of the
plugins.

Combine the pipelines for tag builds of linux and darwin builds of the
terraform provider and event-handler. These are pure Go programs so can
easily be cross-compiled using GOOS/GOARCH. The "tricky" part is the
universal binary, solved by using https://github.com/konoui/lipo - a Go
version of lipo (the tool that constructs universal binaries) that can
run on Linux.

This removes Apple Mac machines from the release pipeline of the
plugins.
@wadells
Copy link
Contributor

wadells commented Sep 21, 2023

Would you link your testing? I think that is the most important merge criteria.

@camscale
Copy link
Contributor Author

@camscale
Copy link
Contributor Author

I have downloaded these builds from the S3 bucket and run them on my Mac (arm64). I needed to first remove the quarantine bit (xattr -d com.apple.quarantine <binary>) from the downloaded binaries, and they both execute fine and produced a help message (event-handler) or the "this is a plugin" message (terraform provider).

@camscale
Copy link
Contributor Author

I have also downloaded the linux versions and tested them in the same way - executing the binaries to ensure they can run. All good, same results:

> ./terraform-provider-teleport
This binary is a plugin. These are not meant to be executed directly.
Please execute the program that consumes these plugins, which will
load any plugins automatically
> ./teleport-event-handler version
Teleport event handler v14.0.0-camh.1 go1.21.1

@camscale camscale merged commit 59742cc into master Sep 21, 2023
@camscale camscale deleted the camh/combine-tag-linux-darwin branch September 21, 2023 22:49
@camscale camscale mentioned this pull request Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants