This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Pin Teleport Terraform Provider to Teleport major version #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
tcsc,
zmb3,
camscale and
fheinecke
as code owners
marcoandredinis
approved these changes
Sep 29, 2023
|
You should also run |
The previous constrain `>= (=teleport.version=)` allows Terraform to pick any version bigger than the specified version. This is a problem because `>= 12.0.0` can actually select `14.0.0` which breaks our client guarantees when connecting to Auth server. This PR forces Terraform to pick any version `>=12.0.0` and `< 13.0.0`. The pessimist version constrain prevents Terraform provider to use versions outside of the specified major version. Signed-off-by: Tiago Silva <[email protected]>
tigrato
force-pushed
the
tigrato/fix-terraform-pinned-version
branch
from
363d40e to
7705d16
Compare
strideynet
approved these changes
Sep 29, 2023
marcoandredinis
approved these changes
Sep 29, 2023
Joerger
approved these changes
Oct 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous constrain
>= (=teleport.version=)allows Terraform to pick any version bigger than the specified version. This is a problem because>= 12.0.0can actually select14.0.0which breaks our client guarantees when connecting to Auth server.This PR forces Terraform to pick any version
>=12.0.0and< 13.0.0. The pessimist version constrain prevents Terraform provider to use versions outside of the specified major version.