Test fixups and review feedback

gravitational · Dec 6, 2024 · 88f231a · 88f231a
1 parent 54ed676
commit 88f231a
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 10 deletions.
diff --git a/api/client/proto/authservice.pb.go b/api/client/proto/authservice.pb.go
diff --git a/api/proto/teleport/legacy/client/proto/authservice.proto b/api/proto/teleport/legacy/client/proto/authservice.proto
@@ -1943,16 +1943,26 @@ message CreateRegisterChallengeRequest {
 // IdentityCenterAccount holds information about an Identity Center account
 // within an IdentityCenterAccountAssignment
 message IdentityCenterAccount {
+  // ID is the AWS-assigned account ID
   string ID = 1;
+
+  // ARN is the full Amazon Resource Name for the AWS account
   string ARN = 2;
+
+  // AccountName is the human-readable name of the account
   string AccountName = 3;
+
+  // Description is a free text description of the account
   string Description = 4;
 }
 
 // IdentityCenterPermissionSet holds information about an Identity Center
 // permission set within an IdentityCenterAccountAssignment
 message IdentityCenterPermissionSet {
+  // ARN is the full Amazon Resource Name for the Permission Set
   string ARN = 1;
+
+  // Name is the human readable name for the Permission Set
   string Name = 2;
 }
 

diff --git a/lib/services/unified_resource_test.go b/lib/services/unified_resource_test.go
@@ -52,6 +52,7 @@ type client struct {
 	services.SAMLIdPServiceProviders
 	services.GitServers
 	services.IdentityCenterAccounts
+	services.IdentityCenterAccountAssignmentGetter
 	types.Events
 }
 
@@ -71,12 +72,13 @@ func newClient(t *testing.T) *client {
 	require.NoError(t, err)
 
 	return &client{
-		Presence:                local.NewPresenceService(bk),
-		WindowsDesktops:         local.NewWindowsDesktopService(bk),
-		SAMLIdPServiceProviders: samlService,
-		Events:                  local.NewEventsService(bk),
-		GitServers:              gitService,
-		IdentityCenterAccounts:  icService,
+		Presence:                              local.NewPresenceService(bk),
+		WindowsDesktops:                       local.NewWindowsDesktopService(bk),
+		SAMLIdPServiceProviders:               samlService,
+		Events:                                local.NewEventsService(bk),
+		GitServers:                            gitService,
+		IdentityCenterAccounts:                icService,
+		IdentityCenterAccountAssignmentGetter: icService,
 	}
 }