protect tracked files with mutex

gravitational · Oct 30, 2024 · c83e2e4 · c83e2e4
1 parent e9516e2
commit c83e2e4
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/tool/teleport/common/sftp.go b/tool/teleport/common/sftp.go
@@ -30,6 +30,7 @@ import (
 	"os/user"
 	"path"
 	"strings"
+	"sync"
 	"sync/atomic"
 	"time"
 
@@ -90,8 +91,12 @@ type allowedOps struct {
 type sftpHandler struct {
 	logger  *log.Entry
 	allowed *allowedOps
-	files   []*trackedFile
-	events  chan<- apievents.AuditEvent
+
+	// mtx protects files
+	mtx   sync.Mutex
+	files []*trackedFile
+
+	events chan<- apievents.AuditEvent
 }
 
 type trackedFile struct {
@@ -245,7 +250,9 @@ func (s *sftpHandler) openFile(req *sftp.Request) (sftp.WriterAtReaderAt, error)
 		return nil, err
 	}
 	trackFile := &trackedFile{file: f}
+	s.mtx.Lock()
 	s.files = append(s.files, trackFile)
+	s.mtx.Unlock()
 
 	return trackFile, nil
 }