Skip to content

Commit

Permalink
Add TODO comment about validating local port
Browse files Browse the repository at this point in the history
  • Loading branch information
ravicious committed Nov 28, 2024
1 parent 00d6bde commit daa9898
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/vnet/app_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,8 @@ func (h *tcpAppHandler) getOrInitializeLocalProxy(ctx context.Context, localPort
if len(h.app.GetTCPPorts()) == 0 {
localPort = 0
}
// TODO(ravicious): For multi-port apps, check if localPort is valid and surface the error in UI.
// https://github.com/gravitational/teleport/blob/master/rfd/0182-multi-port-tcp-app-access.md#incorrect-port

lp, ok := h.portToLocalProxy[localPort]
if ok {
Expand Down

0 comments on commit daa9898

Please sign in to comment.