Skip to content

Commit

Permalink
Resolve comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Joerger committed Oct 3, 2024
1 parent 904b0a0 commit fa9fbf7
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions lib/client/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -3919,12 +3919,11 @@ func (tc *TeleportClient) pwdlessLogin(ctx context.Context, keyRing *KeyRing) (*
return response, trace.Wrap(err)
}

// mfaLocalLogin asks for a password and performs an MFA ceremony. If MFA is not required
// by the cluster settings, the ceremony is a no-op.
// localLogin asks for a password and performs an MFA ceremony.
func (tc *TeleportClient) localLogin(ctx context.Context, keyRing *KeyRing, _ constants.SecondFactorType) (*authclient.SSHLoginResponse, error) {
ctx, span := tc.Tracer.Start(
ctx,
"teleportClient/mfaLocalLogin",
"teleportClient/localLogin",
oteltrace.WithSpanKind(oteltrace.SpanKindClient),
)
defer span.End()
Expand All @@ -3945,10 +3944,6 @@ func (tc *TeleportClient) localLogin(ctx context.Context, keyRing *KeyRing, _ co
Password: password,
MFAPromptConstructor: tc.NewMFAPrompt,
})

// Ignore username returned from proxy
response.Username = ""

return response, trace.Wrap(err)
}

Expand Down

0 comments on commit fa9fbf7

Please sign in to comment.